urandom: fix for Nim 2.0 by using only CryptAcquireContextW
#9
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Before this commit, compiling urandom.nim on Windows with Nim 2.0 would
produce an error:
$ nim c --os:windows uuids/urandom.nim
/foo/pragmagic-uuids/uuids/urandom.nim(15, 8) Error: undeclared identifier: 'useWinUnicode'
This was because Nim 2.0 [1] removed the useWinUnicode identifier [2].
Fix by always using CryptAcquireContextW on Windows.
Fixes: pragmagic#8
[1] https://nim-lang.org/blog/2023/08/01/nim-v20-released.html
[2] nim-lang/Nim@612abda
|
Thanks for the PR! Can you make the change backward-compatible please? So that |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Before this commit, compiling
urandom.nimon Windows with Nim 2.0 would produce an error:This was because Nim 2.0 removed the
useWinUnicodeidentifier.Fix by always using
CryptAcquireContextWon Windows.Fixes: #8
I don't have a Windows machine to test this on. This PR may not be sufficient to make the
uuidspackage work with Nim 2.0 on Windows.