Add omitempty tag to optional spec types #108
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
alok87
approved these changes
Jul 22, 2020
|
Following images were pushed for this change: |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
👋 I'm adding these
omitemptytags in the WPA spec after running into an automation issue. A WPA resource generated from the existingWorkerPodAutoScalerspec is not valid or accepted by the CRD, since bothDeploymentNameandReplicaSetNameare always included, even when not specified. Generated WPA resources end up triggering a violation the oneOf validation, and cannot be applied. The PR omits emptyDeploymentNameandReplicaSetNamefields, along with the optional fields in the WPA spec.