Hide Discord RPC error messages away from user attention #31640
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
frenzibyte
added
type:behavioural
next release
|
Hiding the error is fine and all, but what about fixing it? |
|
Currently investigating that, but at first glance it looks to be the underlying API failing somewhere and it may take some time figuring out a fix for it (see Lachee/discord-rpc-csharp#267), so I thought I could push a PR to silence this and maybe get a hotfix release for this if deemed necessary. |
|
Going to get this in. I think if there's errors, we'll be informed sooner or later that something is broken. This doesn't need to show as a notification. |
peppy
approved these changes
Jan 24, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes the awful experience led by the RPC API suddenly blowing up and spamming every single user with error notifications in #31639. We shouldn't raise error notifications for things which we can't really control.