Don't highlight friends' scores under beatmap's friend score leaderboard #31576
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
This was already brought up in the original PR, was decided to be fine to have #31240 (comment) |
I just had a quick look at that but cannot really agree with that. Filling all items of a leaderboard with a specific colour (other than black) is bound to be a bad idea, regardless of design. At least it shouldn't happen to a leaderboard with always 100% friends. |
|
Sure let's go with this since it's been brought up countless times already. I still think that if this is being perceived as an issue, the fill colour is wrong / too present. |
peppy
approved these changes
Jan 20, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Although the idea to highlight friends' score entries in the leaderboard is good, it means less under the
Friendsleaderboard tab of a beatmap. And too much yellow would make the leaderboard seemingly dirty.So in this PR I added a specific argument for this condition. When the current filter is set to show friends only, the score's background will remain black.
I think we won't encounter this situation in match leaderboards, since it doesn't have a filter tab (yet?).