-
-
Notifications
You must be signed in to change notification settings - Fork 2.4k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fix stutter on intensive storyboards when entering break time with 100% background dim #31506
Conversation
This avoids piled-up overhead when entering break time. It's not great, but it is what we need for now to avoid weirdness.
I got this freak crash stack trace in testing this when messing with the storyboard toggle during player load:
Feels borderline out of scope, but maybe worth adding some safeties here and there to prevent this from being hit... |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
see above
That's painful. I've applied band-aid.. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
it's a stop-gap, but it'll do
This avoids piled-up overhead when entering break time. It's not great, but it is what we need for now to avoid weirdness.
Addresses #31465.