Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix slider end circles not remaining for long enough when hit animations disabled #31390

Merged
merged 2 commits into from
Jan 7, 2025

Conversation

peppy
Copy link
Member

@peppy peppy commented Jan 2, 2025

master:

osu.2025-01-02.at.09.56.44.mp4

this pr:

osu.2025-01-02.at.09.55.43.mp4

@bdach
Copy link
Collaborator

bdach commented Jan 6, 2025

Test failure is relevant - prolonging the lifetime of DrawableSlider now makes it selectable for longer, notably also after the body has faded out and only the slider tail marker is visible.

I'm not sure whether that is intended or not. Should we want to fix this, something like this is slightly dodgy but appears to mostly work:

diff --git a/osu.Game.Rulesets.Osu/Edit/Blueprints/Sliders/SliderSelectionBlueprint.cs b/osu.Game.Rulesets.Osu/Edit/Blueprints/Sliders/SliderSelectionBlueprint.cs
index 3504954bec..740862c9fd 100644
--- a/osu.Game.Rulesets.Osu/Edit/Blueprints/Sliders/SliderSelectionBlueprint.cs
+++ b/osu.Game.Rulesets.Osu/Edit/Blueprints/Sliders/SliderSelectionBlueprint.cs
@@ -626,7 +626,7 @@ private void convertToStream()
 
         public override bool ReceivePositionalInputAt(Vector2 screenSpacePos)
         {
-            if (BodyPiece.ReceivePositionalInputAt(screenSpacePos))
+            if (BodyPiece.ReceivePositionalInputAt(screenSpacePos) && DrawableObject.Body.Alpha > 0)
                 return true;
 
             if (ControlPointVisualiser == null)

bdach
bdach previously approved these changes Jan 6, 2025
Copy link
Collaborator

@bdach bdach left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

As above

@bdach bdach dismissed their stale review January 6, 2025 11:32

whoops that was not supposed to be an approval.

@peppy
Copy link
Member Author

peppy commented Jan 7, 2025

Change seems good, have applied verbatim.

@bdach bdach merged commit d291889 into ppy:master Jan 7, 2025
8 of 10 checks passed
@peppy peppy deleted the slider-end-suppress-fix branch January 14, 2025 11:49
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants