Take custom bank name length into account when collapsing sample point indicators #31352
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…t indicators Would close ppy#31312. Not super happy with the performance overhead of this, but this is already a heuristic-based implementation to avoid every-frame `.ChildrenOfType<>()` calls or similar, so not super sure how to do better. The `Array.Contains()` check stands out in profiling, but without it the indicators can collapse *too* eagerly sometimes.
smoogipoo
approved these changes
Dec 30, 2024
|
Umm is the video below caused by this PR? Should I make a new issue? 2025-01-09.21-13-31.mp4 |
|
i don't see anything wrong there |
like the mechanism looking a little over-reacting. Collapsing even when the input name isn't that wide just rely on "3-characters long so I'm gonna collapse it" |
|
it's doing that because there are 3 indicators on the slider that are almost touching. the thing is collapsing because any longer name causes overlaps. that is intentional. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
RFC. Would close #31312.
Not super happy with the performance overhead of this, but this is already a heuristic-based implementation to avoid every-frame
.ChildrenOfType<>()calls or similar, so not super sure how to do better. TheArray.Contains()check stands out in profiling, but without it the indicators can collapse too eagerly sometimes.