Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix slider end drag marker blocking open of control point piece context menus #31350

Merged
merged 4 commits into from
Dec 30, 2024
Merged

Fix slider end drag marker blocking open of control point piece context menus #31350

merged 4 commits into from
Dec 30, 2024

Conversation

bdach
Copy link
Collaborator

@bdach bdach commented Dec 30, 2024 •
edited by smoogipoo
Loading

@bdach bdach self-assigned this Dec 30, 2024
@pull-request-size pull-request-size bot added size/M and removed size/L labels Dec 30, 2024
@peppy peppy self-requested a review December 30, 2024 12:47
peppy
peppy approved these changes Dec 30, 2024
View reviewed changes
Copy link
Member

@peppy peppy left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Another case of unfortunate input handling in the editor.

@peppy peppy merged commit 73083e1 into ppy:master Dec 30, 2024
8 of 9 checks passed
@bdach bdach deleted the fix-slider-drag-marker-blocking-context-menu branch December 30, 2024 13:28
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@peppy peppy peppy approved these changes

Assignees

@bdach bdach

Labels
area:editor ruleset/osu! size/M
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Cannot right click control point when it is over slider end drag marker in editor
3 participants
@bdach @peppy @smoogipoo