Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Pause playback when entering gameplay test from editor #31303

Merged
merged 2 commits into from
Dec 27, 2024

Conversation

bdach
Copy link
Collaborator

@bdach bdach commented Dec 27, 2024

Closes #31290.

Tend to agree that this is a good idea for gameplay test at least. Not sure about other similar interactions like exiting - I don't think it matters what's done in those cases, because for exiting timing is in no way key, so I just applied this locally to gameplay test.

Closes ppy#31290.

Tend to agree that this is a good idea for gameplay test at least. Not
sure about other similar interactions like exiting - I don't think it
matters what's done in those cases, because for exiting timing is in no
way key, so I just applied this locally to gameplay test.
@peppy peppy merged commit 10ee2e2 into ppy:master Dec 27, 2024
8 of 10 checks passed
@bdach bdach deleted the pause-on-gameplay-test branch December 30, 2024 06:52
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Save beatmap dialog doesn't pause the song when playtesting/exiting the beatmap in the editor
2 participants