Save "featured artists" filter to user settings and disable toggling on iOS #31238
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Susko3
reviewed
Dec 22, 2024
Co-authored-by: Susko3 <[email protected]>
Susko3
reviewed
Dec 22, 2024
osu.Game/Overlays/BeatmapListing/BeatmapSearchGeneralFilterRow.cs
Outdated
Show resolved
Hide resolved
Addressed in fcfab9e |
Joehuu
reviewed
Dec 22, 2024
osu.Game/Overlays/BeatmapListing/BeatmapSearchGeneralFilterRow.cs
Outdated
Show resolved
Hide resolved
peppy
reviewed
Dec 23, 2024
osu.Game/Overlays/BeatmapListing/BeatmapSearchMultipleSelectionFilterRow.cs
Outdated
Show resolved
Hide resolved
Please run tests please run tests please run tests.
peppy
reviewed
Dec 23, 2024
osu.Game/Overlays/BeatmapListing/BeatmapSearchMultipleSelectionFilterRow.cs
Outdated
Show resolved
Hide resolved
peppy
reviewed
Dec 23, 2024
| /// <summary> | ||
| /// "Toggling this filter is disabled in this platform." | ||
| /// </summary> | ||
| public static LocalisableString FeaturedArtistsDisabledTooltip => new TranslatableString(getKey(@"featured_artists_disabled_tooltip"), @"Toggling this filter is disabled in this platform."); |
There was a problem hiding this comment.
this doesn't do anything to explain the "why". you can already see it's disabled by it being greyed out.
maybe a tooltip is fine, but the text needs rethinking.
also an aside since we'll be changing it, but it should read "on this platform", not "in".
There was a problem hiding this comment.
I've added it because it states that the filter is disabled at a platform-level, better than not say anything and have the user think they disabled a setting somewhere or the game is bugged. An explanation would be good if one can be thought of, but at least mentioning that it's happening at a platform-level avoids users thinking it's a bug.
peppy
force-pushed
the
make-featured-artist-setting
branch
from
73b13af to
8762e3f
Compare
peppy
approved these changes
Dec 24, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The toggle will remain visible on iOS but in a grayed and non-interactive state. Hiding it would be misleading since it's always turned on.