-
-
Notifications
You must be signed in to change notification settings - Fork 2.4k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Refactor TaikoDifficultyCalculator
and add DifficultStrain
attributes
#31191
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
lgtm, acc scaling shift was approved by the community on huismetbenen prior
Why are refactors being bundled with actual changes? Surely refactoring should be split out separately out of any actual adjustments to prevent undesirable changes? |
Specifically because in the bundling of pr's we had a separate smoogisheet created purely for the refactor values, as well as a huismet link, and because I didn't want to create a pr solely for increasing the accuracy scale shift to |
I'm going to pretend I saw nothing and trust in your judgement. Please do not disappoint. |
osu.Game.Rulesets.Taiko/Difficulty/TaikoDifficultyAttributes.cs
Outdated
Show resolved
Hide resolved
osu.Game.Rulesets.Taiko/Difficulty/TaikoDifficultyCalculator.cs
Outdated
Show resolved
Hide resolved
osu.Game.Rulesets.Taiko/Difficulty/TaikoDifficultyCalculator.cs
Outdated
Show resolved
Hide resolved
Similar to bdach's comments, I'm a little bit apprehensive about calling this a "refactor" PR when we're refactoring as well as removing existing penalties, adding new difficulty attributes and changing accuracy scaling. I'd be much happier if we could split this into 3:
It might seem overkill but especially given the result of last deploy it'd be nice if we could easily pull these things out where necessary. It would also allow for sheets with isolated diff so we can find any points of failure more easily. |
taikodifficultycalculator
and increase accuracy scalingTaikoDifficultyCalculator
and add DifficultStrain
attributes
First split out of the major PR. Includes
HitObject
creation, cleaner list as more things will be includedCountDifficultStrains
as an attributep_norm
intoDifficultyCalculationUtils