Move "global" scroll-adjusts-volume to a per-screen component-based implementation #31146
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
peppy
added a commit
to peppy/osu
that referenced
this pull request
Dec 16, 2024
…f Ctrl+Shift+Scroll Matches stable. - [ ] Depends on ppy#31146, else this will adjust the global volume.
Merged
1 task
bdach
requested changes
Dec 19, 2024
TheDark98
pushed a commit
to TheDark98/osu
that referenced
this pull request
Jan 14, 2025
…f Ctrl+Shift+Scroll Matches stable. - [ ] Depends on ppy#31146, else this will adjust the global volume.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
RFC. (also will tests pass?)
A bit sick of dealing with this weird behaviour being at a game level.
Moving this to an isolated per-screen implementation makes it very explicit when we want this behaviour to exist.