Access beatmap store via abstract base class #31076
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The intention here is to make things more testable going forward. Specifically, to remove the "back-door" entrance into `BeatmapCarousel` where `BeatmapSets` can be set by tests and bypas/block realm retrieval.
peppy
force-pushed
the
beatmap-store-interface
branch
from
106b00b to
a868c33
Compare
bdach
reviewed
Dec 11, 2024
Comment on lines
-249
to
-251
| // This is performing an unnecessary second lookup on realm (in addition to the subscription), but for performance reasons | ||
| // we require it to be separate: the subscription's initial callback (with `ChangeSet` of `null`) will run on the update | ||
| // thread. If we attempt to detach beatmaps in this callback the game will fall over (it takes time). |
There was a problem hiding this comment.
This comment should probably remain in source? I don't see any reason why it would no longer be valid.
There was a problem hiding this comment.
Discussed IRL, comment should have been deleted in 466ed5d
bdach
approved these changes
Dec 11, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The intention here is to make things more testable going forward. Specifically, to remove the "back-door" entrance into
BeatmapCarouselwhereBeatmapSetscan be set by tests and bypas/block realm retrieval.A few code quality improvements thrown in. Was on the fence as to whether I should actually remove the
BeatmapSetstest flow inBeatmapCarouselsince I am currently looking at replacing/rewriting that class completely, but it was low effort.