Fix reference issues in iOS tests #30729
Conversation
| <ProjectReference Include="..\osu.Game.Rulesets.Taiko\osu.Game.Rulesets.Taiko.csproj" /> | ||
| <ProjectReference Include="..\osu.Game.Tests\osu.Game.Tests.csproj" /> |
There was a problem hiding this comment.
This causes game tests to show up when running iOS taiko test browser, but it doesn't seem to be easily solvable so I'll just let it be for now, it's not offensive enough for me to care.
There was a problem hiding this comment.
The other rulesets already do this (or at least standard does, the others might use the BeatmapImportHelper too), I copied this reference from another ruleset's csproj file.
A more ideal solution might be a project containing commons for all tests.
There was a problem hiding this comment.
I don't see any other test project referencing osu.Game.Tests. Usually whenever a test component is used by more than one test project, it is moved to osu.Game/Tests/... but let's just keep things as they are for now.
There was a problem hiding this comment.
My bad, standard does not have it. This is where I copied it from:
Therefore I assume the usage of BeatmapImportHelper might be exclusive to the Taiko ruleset, and in Taikos' iOS tests it was missing while in the normal tests it wasn't.
osu.Game.Rulesets.Osu.Tests.iOSwas missing references forMoqandDeepEqualosu.Game.Rulesets.Taiko.Tests.iOSwas missing a reference toosu.Game.Tests, causing issues with trying to useosu.Game.Tests.Beatmaps.IO.BeatmapImportHelperBoth caused the tests to not compile.