Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add progress tooltip for ArgonSongProgressBar #30078

Merged
merged 8 commits into from
Oct 7, 2024
Merged

Add progress tooltip for ArgonSongProgressBar #30078

Changes from 1 commit
Commits
Show all changes
8 commits
Select commit Hold shift + click to select a range
4f16ecd
Add progress tooltip for ArgonSongProgressBar
CloneWith Oct 1, 2024
5af05f1
Use play length for timestamp calculation
CloneWith Oct 1, 2024
5dd28d5
Fix extra newline
CloneWith Oct 1, 2024
2d7fdaf
Override OnMouseMove for cursor position fetching
CloneWith Oct 4, 2024
fd56554
Adjust tooltip text format
CloneWith Oct 4, 2024
d7ba4ce
Refactor progress tooltip updating method
CloneWith Oct 4, 2024
b5cc45b
Simplify format code (and adjust formatting slightly)
peppy Oct 7, 2024
6e4eed6
Fix weird mouse position handling and don't return `true` to event
peppy Oct 7, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Prev Previous commit
Next Next commit
Fix extra newline
  • Loading branch information
@CloneWith
CloneWith committed Oct 1, 2024
commit 5dd28d53521b31bc77c55f7d4fd4b6da80b7252a
1 change: 0 additions & 1 deletion osu.Game/Screens/Play/HUD/ArgonSongProgressBar.cs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -20,7 +20,6 @@ namespace osu.Game.Screens.Play.HUD
{
public partial class ArgonSongProgressBar : SongProgressBar, IHasTooltip
{

// Parent will handle restricting the area of valid input.
public override bool ReceivePositionalInputAt(Vector2 screenSpacePos) => true;

Expand Down
Loading