Ensure sliders are snapped when changing path types #30063
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Closes ppy#29915. Uses behaviour suggested in ppy#29915 (comment).
Hitobjects are in an indeterminate state until defaults are applied. Adding the object to the beatmap will do this.
bdach
force-pushed
the
snap-sliders-on-path-type-change
branch
from
b253aa0 to
493dcc7
Compare
|
Yep this is what I meant. We might want to look into applying this behaviour for any slider path change because I noticed the inconsistency. Stuff like moving an anchor seems to always resnap the slider length. |
peppy
approved these changes
Oct 1, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes #29915.
Uses behaviour suggested in #29915 (comment). @OliBomby you might be interested in double-checking if this is what you meant.