Differentiate lazer in windows menus #29822
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Windows has a really unorthodox way of generating human readable names for exe's. To put it simply, it reads the
Description
attribute of the .exe file. This also is not documented anywhere except for a really obscure reference.Lazer, prior to this PR, would default to setting the
![image](https://private-user-images.githubusercontent.com/69545310/365739245-17a3fbef-85bb-45be-b923-0d9d9d8ef905.png?jwt=eyJhbGciOiJIUzI1NiIsInR5cCI6IkpXVCJ9.eyJpc3MiOiJnaXRodWIuY29tIiwiYXVkIjoicmF3LmdpdGh1YnVzZXJjb250ZW50LmNvbSIsImtleSI6ImtleTUiLCJleHAiOjE3MzkxMDA2NDMsIm5iZiI6MTczOTEwMDM0MywicGF0aCI6Ii82OTU0NTMxMC8zNjU3MzkyNDUtMTdhM2ZiZWYtODViYi00NWJlLWI5MjMtMGQ5ZDlkOGVmOTA1LnBuZz9YLUFtei1BbGdvcml0aG09QVdTNC1ITUFDLVNIQTI1NiZYLUFtei1DcmVkZW50aWFsPUFLSUFWQ09EWUxTQTUzUFFLNFpBJTJGMjAyNTAyMDklMkZ1cy1lYXN0LTElMkZzMyUyRmF3czRfcmVxdWVzdCZYLUFtei1EYXRlPTIwMjUwMjA5VDExMjU0M1omWC1BbXotRXhwaXJlcz0zMDAmWC1BbXotU2lnbmF0dXJlPWEzODc5OTE1NzBjMzNkM2E0NWJmZWYwOGQ2MmRlODQ1ZTY2YzZkMzZhZjM4Yjg2NTYyZDM3MjJiMzdmMWNkZTEmWC1BbXotU2lnbmVkSGVhZGVycz1ob3N0In0.gDYfwoM8sIIS0vmNEpruHziQKmOrYjq0p7SF6BE2Zlk)
Description
of the exe to "osu!". This PR changes it so that the exe'sDescription
is osu!lazer. This helps to differentiate between osu!lazer and osu!stable, because nobody wants to deal with thisHere's how it'll look with this PR
![CleanShot 2024-09-09 at 12 47 33@2x](https://private-user-images.githubusercontent.com/69545310/365739396-ee07b867-2415-4f01-bc8e-d2cf90922e5c.png?jwt=eyJhbGciOiJIUzI1NiIsInR5cCI6IkpXVCJ9.eyJpc3MiOiJnaXRodWIuY29tIiwiYXVkIjoicmF3LmdpdGh1YnVzZXJjb250ZW50LmNvbSIsImtleSI6ImtleTUiLCJleHAiOjE3MzkxMDA2NDMsIm5iZiI6MTczOTEwMDM0MywicGF0aCI6Ii82OTU0NTMxMC8zNjU3MzkzOTYtZWUwN2I4NjctMjQxNS00ZjAxLWJjOGUtZDJjZjkwOTIyZTVjLnBuZz9YLUFtei1BbGdvcml0aG09QVdTNC1ITUFDLVNIQTI1NiZYLUFtei1DcmVkZW50aWFsPUFLSUFWQ09EWUxTQTUzUFFLNFpBJTJGMjAyNTAyMDklMkZ1cy1lYXN0LTElMkZzMyUyRmF3czRfcmVxdWVzdCZYLUFtei1EYXRlPTIwMjUwMjA5VDExMjU0M1omWC1BbXotRXhwaXJlcz0zMDAmWC1BbXotU2lnbmF0dXJlPTMwOTRkNGQxYzBhNDg2YjllMTlhMDE4YmYzZDU0YzU5ZDhlN2UzMjYyNDU4ZjA2MjUxMDM3YzE1YjgxZWE2YjYmWC1BbXotU2lnbmVkSGVhZGVycz1ob3N0In0.5gYev7MWJhud0bYuLEyQjXloyGVlqzXfh-Jw5Ked28o)
Tested and confirmed to work on Windows 11 23h2