Code

Save custom sound banks to beatmap#29566

Code

Draft

kstefanowicz wants to merge 15 commits intoppy:masterppy/osu:masterfrom kstefanowicz:save-custom-sound-bankskstefanowicz/osu:save-custom-sound-banksCopy head branch name to clipboard

+85-26

Commits

Commits on Aug 21, 2024

• Add custom sound banks to legacy encoder

  kstefanowicz

  committed
  618792b

  Copy full SHA for 618792b

• Check for custom sound banks first

  kstefanowicz

  committed
  8b31ef2

  Copy full SHA for 8b31ef2

• Add custom sound banks to legacy decoder

  kstefanowicz

  committed
  95daa4c

  Copy full SHA for 95daa4c

• Remove "none" from AvailableSoundBanks

  kstefanowicz

  committed
  4e729ce

  Copy full SHA for 4e729ce

• Adjust formatting

  kstefanowicz

  committed
  02a8676

  Copy full SHA for 02a8676

Commits on Aug 22, 2024

• Move AvailableSampleBanks to ConvertHitObjectParser

  kstefanowicz

  committed
  abea1a5

  Copy full SHA for abea1a5

• Add fallback for invalid bank default to normal

  kstefanowicz

  committed
  eb58837

  Copy full SHA for eb58837

• Fix AvailableSampleBanks.Count to reflect 0-index

  kstefanowicz

  committed
  ecdc3cb

  Copy full SHA for ecdc3cb

• Prevent regular sound banks from being added to CustomSoundBanks in .osu file

  kstefanowicz

  committed
  a1f5679

  Copy full SHA for a1f5679

Commits on Aug 24, 2024

• Move custom sound bank check before writing colors in encoder

  kstefanowicz

  committed
  785ef22

  Copy full SHA for 785ef22

• Add check for IHasRepeats to get banks from sliders

  kstefanowicz

  committed
  a790127

  Copy full SHA for a790127

• Remove MacOS Using

  kstefanowicz

  committed
  9ae49f8

  Copy full SHA for 9ae49f8

• Address null reference warnings

  kstefanowicz

  committed
  2c65fe1

  Copy full SHA for 2c65fe1

• Add check for empty NodeSamples

  kstefanowicz

  committed
  e898433

  Copy full SHA for e898433

Commits on Aug 25, 2024

• Address code quality issues

  kstefanowicz

  committed
  7bb955b

  Copy full SHA for 7bb955b