Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix held gameplay keys stuck after pausing and resuming #28954

Merged
merged 5 commits into from
Jul 20, 2024
Merged

Fix held gameplay keys stuck after pausing and resuming #28954

Changes from 1 commit
Commits
Show all changes
5 commits
Select commit Hold shift + click to select a range
d7651ef
Add extensive test cases for correct input handling while paused in o…
frenzibyte Jul 19, 2024
4f6c7fe
Schedule resume operation by one frame to ensure the triggered key do…
frenzibyte Jul 19, 2024
818b60a
Fix pause overlay hiding input from ruleset input manager
frenzibyte Jul 19, 2024
e539670
Add explanatory note
frenzibyte Jul 19, 2024
401c0fe
Merge branch 'master' into fix-pause-input-handling
peppy Jul 20, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Prev Previous commit
Next Next commit
Add explanatory note
  • Loading branch information
@frenzibyte
frenzibyte committed Jul 19, 2024
commit e539670df1d6d73c077b5a3792ea27c3318e464e
2 changes: 2 additions & 0 deletions osu.Game.Rulesets.Osu/UI/OsuResumeOverlay.cs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -116,6 +116,8 @@ public bool OnPressed(KeyBindingPressEvent<OsuAction> e)

scaleTransitionContainer.ScaleTo(2, TRANSITION_TIME, Easing.OutQuint);

// When resuming with a button, we do not want the osu! input manager to see this button press and include it in the score.
// To ensure that this works correctly, schedule the resume operation one frame forward, since the resume operation enables the input manager to see input events.
Schedule(() => ResumeRequested?.Invoke());
return true;
}
Expand Down
Loading