Match mania editor playfield time range with timeline zoom #28809
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Looks good only weird thing is the fading timeline snaps when clicking usually people make maps zoomed out a lot so only seeing the snaps around where you click is a little weird |
already covered in #24545 ("Snap lines should stay, even if the cursor is not hovering") |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
RFC.
2024-07-10.17-29-33.mp4
Honestly not super sure about this, but it was mentioned as a point in #24545, so gave this a go. Intentionally does not match stable which appears to apply a mostly arbitrary zoom (there appears to be zero apparent correlation between the timeline and the playfield there, so I didn't bother matching or even looking at source what stable did).
Method of application is a bit ad hoc but mania's baseline scroll speed managing code was already a bit more involved than I would have liked, and it's relatively isolated so maybe fine?
This only takes effect when "show scroll speed changes" is off. This is so that enabling that toggle provides an accurate representation of actual gameplay.
Applied locally to mania for now because the other scrolling rulesets didn't have a stable editor and I'm unsure if they would want this. I could see applying this for taiko, using the same behaviour of turning it off when showing scroll speed changes, but probably not for catch, as it would distort SVs there.
This is overlooking the fact that the timeline is generally (as per user feedback) a bit useless for mania right now which is something I'd be looking to address a bit later, probably by having per-ruleset implementations of timeline?