Add basic density consideration to HP drain #26039
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@smoogipoo if I was to do a build today, would you be interested in getting this out for testing? I guess let me know by the end of the day if so. |
|
Yes, I would be interested in getting this out for testing. |
peppy
reviewed
Dec 22, 2023
| (int group, double avgIncrease)[] avgIncreasesByGroup = healthIncreases | ||
| .Where(i => i.Group != null) | ||
| .GroupBy(i => i.Group) | ||
| .Select(g => ((int)g.Key!, g.Sum(i => i.Amount) / (g.Max(i => i.Time) - g.Min(i => i.Time) + 1))) |
There was a problem hiding this comment.
this is definitely something of a line 🙈
peppy
approved these changes
Dec 22, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Builds upon #26012 to add some basic form of density consideration.
I need more time to test this, but PRing for review for now.
The idea I'm going for is to normalise higher-density sections back to more reasonable values so that they don't skew the algorithm too much, while preserving some effects of density. Basically - taking the edge off.
In this implementation, a "section" refers to, at least for the osu! ruleset, a combo colour. This is completely theoretical at this point and I haven't tested the effect of applying the normalisation per-hitobject, but this may lead to more interesting effects around things like 1-combo bursts. Definitely needs more testing.
Replays.zip (compare vs PR above)