Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add versioning of local scores #25998

Merged
merged 5 commits into from
Dec 21, 2023
Merged

Add versioning of local scores #25998

merged 5 commits into from
Dec 21, 2023

Conversation

peppy
Copy link
Member

@peppy peppy commented Dec 21, 2023

For any potential future usage

Minimal implementation as to not spend too much time, just want to get this in place in case we need it.

For any potential future usage
@peppy peppy force-pushed the add-score-version branch from 2f833f1 to a4baa0a Compare December 21, 2023 09:37
/// The version of the client this score was set using.
/// Sourced from <see cref="OsuGameBase.Version"/> at the point of score submission.
/// </summary>
public string Version { get; set; } = string.Empty;
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I guess probably the only question I'd have here is - do we wanna put this in replays too (and decode it from there on import)? We can probably put this in LegacyReplaySoloScoreInfo with practically zero effort.

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Oh yeah. I didn't realise this was so low effort, if so then let's do it.

Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Have done so in 2baf579 (with test coverage in 5ff95db).

@pull-request-size pull-request-size bot added size/M and removed size/S labels Dec 21, 2023
@bdach
Copy link
Collaborator

bdach commented Dec 21, 2023

As discussed on stream I've also renamed the property to ClientVersion in 81bbdcc because I feel we will have too many versions of everything otherwise and invariably get confused.

@peppy would appreciate double-check of changes. Importantly, if you're going to run this, remove client_40.realm* from the development directory, or else it will probably yell that the db is corrupt. This is because I did the rename without bumping schema version again.

@peppy peppy merged commit 716d866 into ppy:master Dec 21, 2023
@peppy peppy deleted the add-score-version branch December 22, 2023 06:03
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants