Update song select to always show difficulty stats #25898
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
The idea - sure. The execution - ehhhhhh... I know this is temporary and all, but I cannot get behind the current appearance of the thing. If it were some throwaway screen, sure, I could agree to lots, but for song select, not so much.
Dunno that I'd agree. Here's a bad case:
I generally don't really get the blue or the glow. I guess the idea was to match the beatmap wedge, but with how much the rest of the screen leans into semi-opaque blacks, it just looks hilariously out of place to me. Looks especially bad when the loading spinner (which uses even more semi-opaque black) shows in front of the beatmap details thing. The padding on the bars is also bothering me greatly. A constructive counterproposal follows:
diff --git a/osu.Game/Screens/Select/BeatmapDetails.cs b/osu.Game/Screens/Select/BeatmapDetails.cs
index 679ebfcf48..dec2c1c1de 100644
--- a/osu.Game/Screens/Select/BeatmapDetails.cs
+++ b/osu.Game/Screens/Select/BeatmapDetails.cs
@@ -5,7 +5,6 @@
using osu.Framework.Allocation;
using osu.Framework.Graphics;
using osu.Framework.Graphics.Containers;
-using osu.Framework.Graphics.Effects;
using osu.Framework.Graphics.Shapes;
using osu.Game.Beatmaps;
using osu.Game.Graphics;
@@ -19,7 +18,6 @@
using osu.Game.Resources.Localisation.Web;
using osu.Game.Screens.Select.Details;
using osuTK;
-using osuTK.Graphics;
namespace osu.Game.Screens.Select
{
@@ -70,21 +68,12 @@ public BeatmapDetails()
CornerRadius = 10;
Masking = true;
- EdgeEffect = new EdgeEffectParameters
- {
- Type = EdgeEffectType.Glow,
- Hollow = true,
- Colour = new Color4(130, 204, 255, 15),
- Radius = 10,
- };
-
Children = new Drawable[]
{
new Box
{
RelativeSizeAxes = Axes.Both,
- Colour = new Color4(130, 204, 255, 40),
- Blending = BlendingParameters.Additive,
+ Colour = Colour4.Black.Opacity(0.3f),
},
new Container
{
diff --git a/osu.Game/Screens/Select/Details/AdvancedStats.cs b/osu.Game/Screens/Select/Details/AdvancedStats.cs
index 66a913fda1..0d68a0ec3c 100644
--- a/osu.Game/Screens/Select/Details/AdvancedStats.cs
+++ b/osu.Game/Screens/Select/Details/AdvancedStats.cs
@@ -92,11 +92,35 @@ public AdvancedStats(int columns = 1)
Direction = FillDirection.Full,
Children = new[]
{
- FirstValue = new StatisticRow { Width = 0.5f }, // circle size/key amount
- HpDrain = new StatisticRow { Title = BeatmapsetsStrings.ShowStatsDrain, Width = 0.5f },
- Accuracy = new StatisticRow { Title = BeatmapsetsStrings.ShowStatsAccuracy, Width = 0.5f },
- ApproachRate = new StatisticRow { Title = BeatmapsetsStrings.ShowStatsAr, Width = 0.5f },
- starDifficulty = new StatisticRow(10, true) { Title = BeatmapsetsStrings.ShowStatsStars, Width = 0.5f },
+ FirstValue = new StatisticRow
+ {
+ Width = 0.5f,
+ Padding = new MarginPadding { Right = 5, Vertical = 2.5f },
+ }, // circle size/key amount
+ HpDrain = new StatisticRow
+ {
+ Title = BeatmapsetsStrings.ShowStatsDrain,
+ Width = 0.5f,
+ Padding = new MarginPadding { Left = 5, Vertical = 2.5f },
+ },
+ Accuracy = new StatisticRow
+ {
+ Title = BeatmapsetsStrings.ShowStatsAccuracy,
+ Width = 0.5f,
+ Padding = new MarginPadding { Right = 5, Vertical = 2.5f },
+ },
+ ApproachRate = new StatisticRow
+ {
+ Title = BeatmapsetsStrings.ShowStatsAr,
+ Width = 0.5f,
+ Padding = new MarginPadding { Left = 5, Vertical = 2.5f },
+ },
+ starDifficulty = new StatisticRow(10, true)
+ {
+ Title = BeatmapsetsStrings.ShowStatsStars,
+ Width = 0.5f,
+ Padding = new MarginPadding { Right = 5, Vertical = 2.5f },
+ },
},
};
break;
diff --git a/osu.Game/Screens/Select/SongSelect.cs b/osu.Game/Screens/Select/SongSelect.cs
index 208a8eb321..0d302dc561 100644
--- a/osu.Game/Screens/Select/SongSelect.cs
+++ b/osu.Game/Screens/Select/SongSelect.cs
@@ -13,7 +13,6 @@
using osu.Framework.Extensions.ObjectExtensions;
using osu.Framework.Graphics;
using osu.Framework.Graphics.Containers;
-using osu.Framework.Graphics.Effects;
using osu.Framework.Graphics.Shapes;
using osu.Framework.Graphics.Sprites;
using osu.Framework.Graphics.UserInterface;
@@ -274,28 +273,20 @@ private void load(AudioManager audio, OsuColour colours, ManageCollectionsDialog
RelativeSizeAxes = Axes.Both,
Masking = true,
CornerRadius = 10,
- EdgeEffect = new EdgeEffectParameters
- {
- Type = EdgeEffectType.Glow,
- Hollow = true,
- Colour = new Color4(130, 204, 255, 15),
- Radius = 10,
- },
Children = new Drawable[]
{
new Box
{
- Colour = new Color4(130, 204, 255, 40),
- Blending = BlendingParameters.Additive,
RelativeSizeAxes = Axes.Both,
+ Colour = Colour4.Black.Opacity(0.3f),
},
advancedStats = new AdvancedStats(2)
{
RelativeSizeAxes = Axes.X,
AutoSizeAxes = Axes.Y,
- Width = 0.8f,
Anchor = Anchor.Centre,
Origin = Anchor.Centre,
+ Padding = new MarginPadding(10)
},
}
},
|
|
I also like the proposal better |
|
I have a personal aversion to greys / blacks used like this, but I'm not going to take issue with it for now since it's used in so many other places on the screen. Have applied changes, thanks! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
We have a larger redesign planned, but let's just get this in so people can easily see both leaderboards and beatmap stats.
Yes, tags text may have low contrast. No I don't really care at this point (it's still legible in all cases, even pure white background), but I am reluctantly open to better looking colour suggestions.
This also sets the default display mode to local leaderboard, instead of details, as it's a better look.
2023-12-21.02.43.54.mp4