Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix some beatmaps being reprocessed each startup #25895

Merged
merged 2 commits into from
Dec 19, 2023
Merged

Fix some beatmaps being reprocessed each startup #25895

merged 2 commits into from
Dec 19, 2023

Conversation

peppy
Copy link
Member

@peppy peppy commented Dec 19, 2023 •
edited by bdach
Loading

Had this happen for around 190 beatmaps on every startup. Follows by example (StarRating also does similarly use -1 as default).

@peppy peppy added the realm deals with local realm database label Dec 19, 2023
@bdach bdach added the next release Pull requests which are almost there. We'll aim to get them in the next release, but no guarantees! label Dec 19, 2023
bdach
bdach approved these changes Dec 19, 2023
View reviewed changes
Copy link
Collaborator

@bdach bdach left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

it'll do. seems to do the job at least

@bdach bdach merged commit 1ebb626 into ppy:master Dec 19, 2023
@peppy peppy deleted the fix-beatmap-statsitics-reprocessing branch December 22, 2023 06:03
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@bdach bdach bdach approved these changes

Assignees
No one assigned
Labels
next release Pull requests which are almost there. We'll aim to get them in the next release, but no guarantees! realm deals with local realm database size/M
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Beatmaps with no hit objects are always being recalculated/populated with missing statistics
2 participants
@peppy @bdach