Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Change default slider velocity for new beatmaps to match osu!stable #25688

Merged
merged 4 commits into from
Dec 7, 2023

Conversation

peppy
Copy link
Member

@peppy peppy commented Dec 6, 2023

This is the default in osu!stable (ie. on creating a new beatmap in the editor) and plays better than 1.0.

@peppy
Copy link
Member Author

peppy commented Dec 6, 2023

!diffcalc

Copy link

github-actions bot commented Dec 6, 2023

@peppy
Copy link
Member Author

peppy commented Dec 6, 2023

!diffcalc
RULESET=taiko

@peppy
Copy link
Member Author

peppy commented Dec 6, 2023

!diffcalc
RULESET=catch

@peppy
Copy link
Member Author

peppy commented Dec 6, 2023

!diffcalc
RULESET=mania

Copy link

github-actions bot commented Dec 6, 2023

Copy link

github-actions bot commented Dec 6, 2023

Copy link

github-actions bot commented Dec 6, 2023

Don't even ask. Just smile and nod.
Copy link
Collaborator

@bdach bdach left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This part seems likely to be fine, although I will hold out for the diffcalc results. Stable appears to be behaving similarly based on a little debugging.

@bdach
Copy link
Collaborator

bdach commented Dec 6, 2023

taiko is showing differences, but the diffcalc run is for whatever reason comparing with a month-old rev (1a86366) and we've had other changes to taiko since then, most notably the drumroll length fixes which are likely to be the real culprit for this. For one the star ratings reported as mismatched on the sheet match on latest master.

@bdach
Copy link
Collaborator

bdach commented Dec 6, 2023

I found the place that pinned the diffcalc sheet generator to the old rev and modified it to hopefully always use latest, so gonna queue up a rerun of the taiko one now...

!diffcalc
RULESET=taiko

Copy link

github-actions bot commented Dec 6, 2023

@bdach
Copy link
Collaborator

bdach commented Dec 6, 2023

Just for my peace of mind gonna re-run mania too, since I noticed SR changes there as well...

!diffcalc
RULESET=mania

Copy link

github-actions bot commented Dec 6, 2023

@peppy peppy merged commit a500f55 into ppy:master Dec 7, 2023
16 checks passed
@peppy peppy deleted the match-default-sv branch December 7, 2023 04:46
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants