Fix taiko and mania using the incorrect slider length when converting beatmaps #25595
Conversation
smoogipoo
added
ruleset/osu!taiko
ruleset/osu!mania
area:beatmap-parsing
| else | ||
| distance = distanceData.Distance; |
There was a problem hiding this comment.
Does this fallback case realistically get hit under some scenario?
There was a problem hiding this comment.
As far as I can tell, no. I only added it for sanity/safety.
|
!diffcalc |
|
Taiko spreadsheet above looks good to me. Checked https://osu.ppy.sh/beatmapsets/217667#osu/1151178 and https://osu.ppy.sh/beatmapsets/884669#taiko/1935058 and confirmed the new conversions match osu-stable. Just going to run mania too for sanity's sake... !diffcalc |
|
Mania also looks good. Tested https://osu.ppy.sh/beatmapsets/1749133#mania/3578111 and, although it is now impossible to play and looks weird, it matches osu!stable. This PR's good to go from me now. |
Fixes #20902
Basically, in osu!stable, the distance for these conversion functions is extracted so early that the rest of the slider code doesn't actually get run. It uses the value from the beatmap file directly. Compare that to lazer, which was using the post-processed distance.
I've only tested this with the given beatmap, but I will run a diffcalc on this PR and check additional cases (there should hopefully be some differences I can check).