-
-
Notifications
You must be signed in to change notification settings - Fork 2.4k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fix spectator not immediately showing when a spectated user fails #25566
Conversation
Create a new stack each time for isolation and safety
The source here looks okay, but:
2023-11-27.11-54-40.mp4Also it looks that if the spectated player quits at the retry overlay, the spectating player will not be sent back to the spectator screen. |
It has not failed since in several tries, so I will pretend I did not see that...
Fixed by cherry-picking a4be28a out of previous iteration.
As discussed IRL last week (and then promptly forgotten by me since I have the memory of a goldfish), this is not simple to make happen because the spectator server has no way of knowing about the quit (the player has already "ended playing" by then, by way of failing). |
Supersedes and closes #25550.
CleanShot.2023-11-24.at.06.07.20.mp4