Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix spectator not immediately showing when a spectated user fails #25566

Merged
merged 9 commits into from
Nov 27, 2023

Conversation

peppy
Copy link
Member

@peppy peppy commented Nov 24, 2023

Supersedes and closes #25550.


CleanShot.2023-11-24.at.06.07.20.mp4

@bdach bdach added the next release Pull requests which are almost there. We'll aim to get them in the next release, but no guarantees! label Nov 27, 2023
@bdach
Copy link
Collaborator

bdach commented Nov 27, 2023

The source here looks okay, but:

  • I have had this fail to trigger failure for me on the very first try of this and I am unable to reproduce it which is unnerving.
  • The retry button on the spectating player's side does things it shouldn't:
2023-11-27.11-54-40.mp4

Also it looks that if the spectated player quits at the retry overlay, the spectating player will not be sent back to the spectator screen.

@bdach
Copy link
Collaborator

bdach commented Nov 27, 2023

I have had this fail to trigger failure for me on the very first try of this and I am unable to reproduce it which is unnerving.

It has not failed since in several tries, so I will pretend I did not see that...

The retry button on the spectating player's side does things it shouldn't:

Fixed by cherry-picking a4be28a out of previous iteration.

Also it looks that if the spectated player quits at the retry overlay, the spectating player will not be sent back to the spectator screen.

As discussed IRL last week (and then promptly forgotten by me since I have the memory of a goldfish), this is not simple to make happen because the spectator server has no way of knowing about the quit (the player has already "ended playing" by then, by way of failing).

@bdach bdach merged commit 6eebf63 into ppy:master Nov 27, 2023
@peppy peppy deleted the show-spectator-fail-2 branch November 28, 2023 09:08
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
area:spectator next release Pull requests which are almost there. We'll aim to get them in the next release, but no guarantees! size/L
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants