Add second level menu for editors #25561
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
smoogipoo
previously approved these changes
Nov 24, 2023
smoogipoo
previously approved these changes
Nov 24, 2023
peppy
dismissed
smoogipoo’s stale review
The merge-base changed after approval.
smoogipoo
approved these changes
Nov 24, 2023
|
Was it intended for the editor buttons to both use the final sound instead of being like the play buttons where there is an intermediate sound in between? |
Well spotted, fixed in a44edfd. |
|
In the editor submenu, the osu logo can be clicked but doesn't bring anywhere, feels weird, should open the beatmap editor instead (the leftmost and more likely button like with "play"). Sorry for 2nd bump. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
As mentioned in #25555, while the skin editor has evolved to be really powerful, it's very hidden in the interface. To solve this, I've added a second level menu under the "Edit" button to house all editors.
Icons probably need some thought (@arflyte) as the same editor icon is currently being shared between the beatmap and skin editor.
CleanShot.2023-11-24.at.04.26.52.mp4