Update the last played date of a beatmap when importing a replay by the local user #25303
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
peppy
added
area:import
bdach
reviewed
Oct 30, 2023
Comment on lines
+188
to
+189
| // This needs to be run after user detail population to ensure we have a valid user id. | ||
| if (api.IsLoggedIn && api.LocalUser.Value.OnlineID == model.UserID && (model.BeatmapInfo.LastPlayed == null || model.Date > model.BeatmapInfo.LastPlayed)) |
There was a problem hiding this comment.
I guess this is accepting that due to how the replay format works, username changes can potentially cause the score to be misattributed to the local user and thus also change the last played date?
I guess it's not a huge deal but I do wanna ask to make sure we want to keep using this piece of potentially-unreliable data for more stuff.
There was a problem hiding this comment.
There's an assumption the flow here will be replaced / get more reliable going forward. Username changes are an edge case that will affect 1 in 100,000
bdach
approved these changes
Oct 30, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Improves the situation with #25296.
With this change, importing beatmaps scores from stable will now choose a more correct "Last Played" date for beatmaps based on the most recent score imported.
This also applies when importing one of your own scores at any point.