Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update country code names to match database #25217

Merged
merged 6 commits into from
Oct 25, 2023

Conversation

peppy
Copy link
Member

@peppy peppy commented Oct 24, 2023

Required for ASS / osu-web cross-compatibility

Required for ASS / osu-web cross-compatibility
@nanaya
Copy link

nanaya commented Oct 24, 2023

I haven't checked the rest but at least CZ doesn't match either

@peppy
Copy link
Member Author

peppy commented Oct 24, 2023

Yeah I figure there are others. Wasn't really bothering since these are the only in world cups so far, but I'll do a full pass i guess.

@bdach
Copy link
Collaborator

bdach commented Oct 24, 2023

Not sure what to think of this change because apparently neither source is really consistent with each other, or current reality. The updated list of countries:

  • contains countries that don't exist anymore ("Netherlands Antilles"),
  • doesn't contain countries that exist now ("South Sudan" - see the compile failure caused by that even),
  • has entries like "Anonymous Proxy", "Satellite Provider", or "Other"

But I guess as long as the ground truth is matching then it's probably fine. Just need to fix the compile failure somehow (by either re-adding the missing enum member or deleting the mapping from CountryExtensions).

Oh and any of the countries added here will throw if the "Add all countries" button is used in the tournament client:

default:
throw new ArgumentOutOfRangeException(nameof(country));

@bdach bdach merged commit 2a07506 into ppy:master Oct 25, 2023
@peppy peppy deleted the update-country-codes branch October 25, 2023 10:24
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants