Fix insufficient leniency when querying sample points #25179
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Definitely needs to match if it doesn't already. Separate PR or issue sounds fine. |
peppy
approved these changes
Oct 20, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Compare: https://github.com/peppy/osu-stable-reference/blob/master/osu!/GameplayElements/HitObjects/HitObject.cs#L319.
This fixes the linked case, but is only sorta-kinda correct in general. Only "normal" samples use the stable code path linked above, exceptions such as
sliderslidedo not, and they don't seem to be applying the 5ms leniency anywhere. With this change, lazer will apply the leniency to both, assliderslidesamples are constructed based on the "normal" ones. But that's probably fine...?I'm not sure if we want to do the "8% minimum volume" thing on top of this, and if so, how. Maybe one for a separate issue? Or maybe we ignore until somebody complains?