SFX tweaks #25178

nekodex · 2023-10-20T08:09:46Z

A bunch of little fixes grouped together:

Fixes toolbar ruleset buttons not having hover sounds
Replaces NowPlayingOverlay pop-in/pop-out sounds with newer generic overlay pop-in/pop-out ones
Changes NewsCard select samples from Default sample set to Button
Reduces LoginOverlay sample panning to match NowPlayingOverlay
Changes back button sample set (in KeyBindingPanel) from ButtonSidebar to Default
Adds keypress feedback/sound when binding keys (in KeyBindingPanel)
Changes RevertToDefaultButton from Button sample set to Default

… the generic overlay ones

…to match other toolbar buttons

…ingOverlay`

…leset instead

nekodex added the audio label Oct 20, 2023

nekodex self-assigned this Oct 20, 2023

pull-request-size bot added the size/M label Oct 20, 2023

peppy self-requested a review October 20, 2023 10:15

nekodex added 7 commits October 20, 2023 21:01

Fix toolbar ruleset buttons not having hover sounds

6e8a4c2

Remove NowPlayingOverlay custom pop-in/pop-out samples in favour of…

ba6e36b

… the generic overlay ones

Use Button sample set for NewsCard

bf608a6

Change ruleset button hover samples to Default instead of Button …

e17c94d

…to match other toolbar buttons

Reduce LoginOverlay pop-in/pop-out sample panning to match `NowPlay…

6dc4dbd

…ingOverlay`

Change RevertToDefaultButton and BackButton to use Default samp…

6b28f85

…leset instead

Add audio feedback for when keys are pressed during key binding

fbf8f52

nekodex force-pushed the sfx-tweaks branch from 5773211 to fbf8f52 Compare October 20, 2023 12:01

peppy approved these changes Oct 20, 2023

View reviewed changes

peppy merged commit 3cdcdba into ppy:master Oct 20, 2023

Provide feedback