Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Apply a few more object sizing limits #25110

Merged
merged 2 commits into from
Oct 13, 2023
Merged

Conversation

peppy
Copy link
Member

@peppy peppy commented Oct 13, 2023

These are the few I can think of immediately. We can deal with others as they come up, but I'd rather close the tracking issue for now.

Closes #24940.

@bdach
Copy link
Collaborator

bdach commented Oct 13, 2023

Seems probably fine even without the data on sliderscorepoint. I've checked the collection of random skins I have accumulated locally and saw no breakage, even on skins that have what I'd consider to be comically large sprites for that element. And I can't see a logical explanation for making the tick larger than the actual slider radius itself.

If people complain we'll ask for data and redo.

@bdach bdach merged commit 4e1d564 into ppy:master Oct 13, 2023
@peppy peppy deleted the limit-extra-elements branch October 14, 2023 11:16
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Second pass on element sizing (specifically followpoint)
2 participants