Remove remaining usages of LargeTick{Hit,Miss} in mania
#25100
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Large ticks are not a thing in mania anymore, so the judgement counter tests began to fail as `LargeTickHit` is no longer a valid hit result in that ruleset.
peppy
approved these changes
Oct 12, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
A few minor stragglers from #25062. Noticed when reviewing #25096.
Of particular note, removal of
LargeTickHitfromGetValidHitResults()means that it will stop showing up in several places that deal with judgement counts and so on. One such place is the results screen, which would actually continue to show tick counts on results for old scores prior to the aforementioned pull, but not on scores set after it.Another is the skinnable judgement counter display, wherein deleting
LargeTickHitcaused... test failures, as the test scene was using mania for ruleset, and usingLargeTickHitspecifically for counts, which would not be shown after the aforementioned removal. That was switched to use osu! instead.