Adjust argon health bar to fit with existing layout #25030
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
bdach
added
the
next release
bdach
approved these changes
Oct 6, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes #25014
To make things fit so we can show this off in the next release, I've made some changes and added some configurability.
The health bar is now relative sized
This is to make it work with the fullscreen layout. The final layout needs it to be non-relative-sized. We'll deal with that when we need to. I'm still figuring out how that can work in my head.
The white bar at the left is no longer contained within it
This allows the bar to be used more flexibly by users in their own skins, IMO. The white bars in the argon skin design should be a very simple skinnable component (that exposes a colour and corner radius or similar) which is not attached directly to the elements.
osu.2023-10-06.at.10.27.56.mp4