Add initial animation for health bars #24986
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
bdach
force-pushed
the
health-animates-in-intro
branch
from
0a34168 to
bd71403
Compare
|
Attempted to resolve conflicts here (sorry for the force, screwed the first attempt). Please double check. |
bdach
reviewed
Oct 4, 2023
peppy
added
the
next release
|
I've found and attempted to fix an issue wherein Looks good otherwise. |
bdach
approved these changes
Oct 6, 2023
peppy
commented
Oct 7, 2023
| @@ -107,7 +107,9 @@ private void finishInitialAnimation() | |||
| // aside from the repeating `initialIncrease` scheduled task, | |||
| // there may also be a `Current` transform in progress from that schedule. | |||
| // ensure it plays out fully, to prevent changes to `Current.Value` being discarded by the ongoing transform. | |||
| FinishTransforms(); | |||
| // and yes, this funky `targetMember` spec is seemingly the only way to do this | |||
| // (see: https://github.com/ppy/osu-framework/blob/fe2769171c6e26d1b6fdd6eb7ea8353162fe9065/osu.Framework/Graphics/Transforms/TransformBindable.cs#L21) | |||
|
The logic isn't pretty, but this is supposed to be a very quick implementation which gets built on (or replaced) so 🙈 . |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Pretty jank and I'm not sure how to make better, or how to get it matching stable. Probably need to make a subcomponent which is operating in game time to track the interpolation correctly. Main goal was to breathe some life back into things, so maybe this is fine as a first step.