Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Improve scoring test scene usability #24790

Merged
merged 5 commits into from
Sep 12, 2023

Conversation

bdach
Copy link
Collaborator

@bdach bdach commented Sep 12, 2023

Prelude to #23763

  • Add black background to avoid clashes with background images.
  • Use sorta-tetradic colours for the four plots.
  • Add capability to toggle individual graphs.

master:

1694515890

this PR:

2023-09-12.12-51-59.mp4

Next step will be multiple ruleset support, but I need to sit down and figure out how to get there.

- Add black background to avoid clashes with background images.
- Use sorta-tetradic colours for the four plots.
});
}
}

public class ScoringAlgorithm
Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This is kinda fast-and-loose, especially with the bindable, but I figure it's a test and I didn't want to hem and haw over this too much. Will change on request though.

@bdach
Copy link
Collaborator Author

bdach commented Sep 12, 2023

Added one more - ability to toggle between relative/absolute Y axis:

2023-09-12.13-30-51.mp4

@peppy peppy self-requested a review September 12, 2023 12:01
@peppy peppy merged commit 3aca295 into ppy:master Sep 12, 2023
@bdach bdach deleted the scoring-test-scene-improvements branch September 12, 2023 12:10
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants