Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Disable redundant verbatim string prefix inspections #24668

Merged

Conversation

bdach
Copy link
Collaborator

@bdach bdach commented Aug 28, 2023

For some reason this started flaring up recently all over for me and showing inspections all over:

1693219650

which are technically valid, but interfere with our convention of using verbatim string prefixes to denote non-localisable strings. This, as a result, led to circular inspections (addressing the r# inspection results in getting the osu-localisation-analyser one, addresssing that one results in getting the r# inspection back, etc. ad nauseam).

For some reason this started flaring up recently all over for me and
showing inspections all over, which are _technically_ valid, but
interfere with our convention of using verbatim string prefixes to
denote non-localisable strings. This, as a result, led to circular
inspections (addressing the r# inspection results in getting the
osu-localisation-analyser one, addresssing that one results in
getting the r# inspection back, etc. ad nauseam).
@peppy peppy merged commit d701a25 into ppy:master Aug 28, 2023
@bdach bdach deleted the disable-redundant-verbatim-string-prefix-inspections branch August 28, 2023 12:52
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants