Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix tracking on empty control point groups #24577

Merged
merged 2 commits into from
Aug 18, 2023
Merged

Conversation

OliBomby
Copy link
Contributor

Small issue I noticed. When adding a control point you might at some point have a control point group with no control points in it. This could happen because you for instance deselect the 'effects' section and then select the 'timing' section. However the moment you deselect the 'effects' section and there are no sections active, your selection gets moved to the previous effect control point group because of tracking. The control point group with no control points is very hard to select because the game remembers the tracked type and tries to select those types of control point groups.

This PR fixes the issue.

One unintended behaviour of this change is that when a control point group with no control points is selected, tracking is disabled, so it will not automatically move to the next control point group. I think this is fine though since the area of effect of this control point group with no control points is undefined so technically there is no "next group" which overrides the effect.

@peppy
Copy link
Member

peppy commented Aug 18, 2023

I guess this is okay for now because it was severely broken. But the eventual goal would have the "groups" hidden to the user (which may mean just removing the group when there's no types assigned to it automatically).

@peppy peppy enabled auto-merge August 18, 2023 08:27
@peppy peppy disabled auto-merge August 18, 2023 09:00
@peppy peppy merged commit f51e2a9 into ppy:master Aug 18, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants