Fix tracking on empty control point groups #24577
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Small issue I noticed. When adding a control point you might at some point have a control point group with no control points in it. This could happen because you for instance deselect the 'effects' section and then select the 'timing' section. However the moment you deselect the 'effects' section and there are no sections active, your selection gets moved to the previous effect control point group because of tracking. The control point group with no control points is very hard to select because the game remembers the tracked type and tries to select those types of control point groups.
This PR fixes the issue.
One unintended behaviour of this change is that when a control point group with no control points is selected, tracking is disabled, so it will not automatically move to the next control point group. I think this is fine though since the area of effect of this control point group with no control points is undefined so technically there is no "next group" which overrides the effect.