Update InspectCode to 2022.3.3 and enable C# 11

[huoyaoyuan]

Prerequisite of #23282

Both 2023.1 and 2023.2EAP crashes hardly. I've test that 2022.3 version can inspect #23282 successfully.

The suppression is for reporting $(MSBuildThisFileDirectory) as unknown property. I don't think this feature is correct in any form because $(MSBuildThisFileDirectory) is well-known for a long term.

[bdach]

The suppression is for reporting $(MSBuildThisFileDirectory) as unknown property.

The relevant youtrack report for this seems to be https://youtrack.jetbrains.com/issue/RSRP-490805 https://youtrack.jetbrains.com/issue/RSRP-490368. I've added an inline comment next to the suppression for reference.

[peppy]

Sorry but had to revert this (dc421bd). Can no longer build the game with .NET 6 SDK, so we'll need to wait a bit longer before making this change.

osu on  master via .NET v6.0.408
❯ dotnet build
MSBuild version 17.3.2+561848881 for .NET
  Determining projects to restore...
  Restored /Users/dean/Projects/osu/osu.Game.Rulesets.Osu.Tests.Android/osu.Game.Rulesets.Osu.Tests.Android.csproj (in 7.32 sec).
  Restored /Users/dean/Projects/osu/osu.Game.Tests.Android/osu.Game.Tests.Android.csproj (in 7.32 sec).
  Restored /Users/dean/Projects/osu/osu.Game.Rulesets.Catch.Tests.Android/osu.Game.Rulesets.Catch.Tests.Android.csproj (in 7.32 sec).
  Restored /Users/dean/Projects/osu/osu.Game.Rulesets.Mania.Tests.Android/osu.Game.Rulesets.Mania.Tests.Android.csproj (in 7.32 sec).
  Restored /Users/dean/Projects/osu/osu.Game.Rulesets.Taiko.Tests.Android/osu.Game.Rulesets.Taiko.Tests.Android.csproj (in 7.32 sec).
  Restored /Users/dean/Projects/osu/osu.Android/osu.Android.csproj (in 7.41 sec).
  22 of 28 projects are up-to-date for restore.
CSC : error CS1617: Invalid option '11.0' for /langversion. Use '/langversion:?' to list supported values. [/Users/dean/Projects/osu/osu.Game/osu.Game.csproj]

Build FAILED.

CSC : error CS1617: Invalid option '11.0' for /langversion. Use '/langversion:?' to list supported values. [/Users/dean/Projects/osu/osu.Game/osu.Game.csproj]
    0 Warning(s)
    1 Error(s)

Time Elapsed 00:00:11.64

[huoyaoyuan]

Can no longer build the game with .NET 6 SDK

Hm, doesn't CI specifies the lowest SDK version we want to support?

BTW there are some further optimizations that requires .NET 7. How should the update be driven?

[peppy]

Start at framework side and work outwards. Make sure to benchmark said optimisations to see how much they benefit us, as that may change the priority of switching to 7.