Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add beatmap-level velocity setting to difficulty settings #23431

Merged
merged 10 commits into from
May 9, 2023

Conversation

peppy
Copy link
Member

@peppy peppy commented May 8, 2023

This was weirdly missing until now. In stable, this allows setting a base slider velocity, which becomes the "1.0x" value for the whole beatmap. It is used by mappers to adjust the general "speed" or flow of the beatmap at a high level.

I've also updated the inspector displays to factor this in (and show post-multiplied values).

As discussed in #23391.

osu.2023-05-08.at.04.53.04.mp4

peppy added 8 commits May 8, 2023 13:13
The intention was to give an idea of what the most common velocity of
the beatmap is, but in hindsight, because the "base" velocity is being
set elsewhere this doesn't make sense. It will/should be 1.0x.

Showing this range is still valuable, though.
I think this makes the most sense of the iterations I've tested so far, albeit maybe being a touch too verbose.
@peppy peppy added the next release Pull requests which are almost there. We'll aim to get them in the next release, but no guarantees! label May 8, 2023
@bdach bdach added the blocked Don't merge this. label May 8, 2023
@pull-request-size pull-request-size bot added size/M and removed size/L labels May 9, 2023
@bdach bdach removed the blocked Don't merge this. label May 9, 2023
@bdach bdach merged commit e85afeb into ppy:master May 9, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
area:editor next release Pull requests which are almost there. We'll aim to get them in the next release, but no guarantees! size/M
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants