Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Use stable sort for catch hyperdash generation #22499

Merged
merged 8 commits into from
Dec 13, 2023
Merged

Use stable sort for catch hyperdash generation #22499

Changes from 1 commit
Commits
Show all changes
8 commits
Select commit Hold shift + click to select a range
f8a5ce0
Use stable sort for catch hyperdash generation
ekrctb Feb 2, 2023
491ba13
Factor out palpable obejct enumeration logic
ekrctb Feb 3, 2023
4e18008
Merge branch 'master' into catch-hyperdash-stable-sort
smoogipoo Sep 19, 2023
bbe9d95
Merge branch 'master' into catch-hyperdash-stable-sort
smoogipoo Oct 4, 2023
0652ea3
Merge branch 'master' into catch-hyperdash-stable-sort
bdach Dec 4, 2023
bb198e0
Add test coverage for missing hyperdashes on simultaneous notes
bdach Dec 4, 2023
fcb6f40
Prioritise hyperfruit over non-hyperfruit if simultaneous
bdach Dec 4, 2023
c255339
Merge branch 'master' into catch-hyperdash-stable-sort
smoogipoo Dec 13, 2023
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion osu.Game.Rulesets.Catch/Beatmaps/CatchBeatmapProcessor.cs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -209,7 +209,7 @@ private static void initialiseHyperDash(IBeatmap beatmap)
}
}

palpableObjects.Sort((h1, h2) => h1.StartTime.CompareTo(h2.StartTime));
palpableObjects = palpableObjects.OrderBy(h => h.StartTime).ToList();
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

If the stability of the sort is important, then there should be an inline comment about it or a test covering it. Or both. Otherwise there's no transparent reason why this particular one way to sort out of the multiple ones offered by the standard library is used here precisely.


double halfCatcherWidth = Catcher.CalculateCatchWidth(beatmap.Difficulty) / 2;

Expand Down