Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Slider tick/end misses shows full size Judegement on stable skins #25987

Closed
Tunnelbliick opened this issue Dec 21, 2023 · 2 comments · Fixed by #26003
Closed

Slider tick/end misses shows full size Judegement on stable skins #25987

Tunnelbliick opened this issue Dec 21, 2023 · 2 comments · Fixed by #26003

Comments

@Tunnelbliick
Copy link

Tunnelbliick commented Dec 21, 2023

Type

Cosmetic

Bug description

Stable skins show a full sized miss for missed slider tick / slider end.

This leads to very distracting gameplay, aswell as thinking that you missed eventho you just missed a slider tick / end.
Especially on tech heavy maps or maps with very fast reverse sliders where you frequently can drop slider ends / ticks this is very confusing.

Id recommend making this a toggelable option aswell as it may not be wanted by everyone.

Skin i used

Screenshots or videos

https://streamable.com/x4l1t9

Version

2023.1221.0-lazer

Logs

compressed-logs.zip

@Tunnelbliick Tunnelbliick changed the title Slider end misses shows full size miss Judegement on older skins Slider tick/end misses shows full size Judegement on stable skins Dec 21, 2023
@peppy peppy self-assigned this Dec 21, 2023
@NiceAesth
Copy link
Contributor

NiceAesth commented Dec 21, 2023

This happens on skins which have miss sprites with very tall textures.

Left: skin that does not scale correctly
Right: skin that does

hit0.zip

@bdach bdach assigned bdach and unassigned peppy Dec 21, 2023
@bdach
Copy link
Collaborator

bdach commented Dec 21, 2023

nope the tallness of the sprite has no impact.

spot the actual issue:

// legacy judgements don't play any transforms if they are an animation.... UNLESS they are the temporary displayed judgement from new piece.
if (animation?.FrameCount > 1 && !forceTransforms)
return;
if (result.IsMiss())
{
bool isTick = result != HitResult.Miss;
if (isTick)
{
this.ScaleTo(0.6f);
this.ScaleTo(0.3f, 100, Easing.In);
}

bdach added a commit to bdach/osu that referenced this issue Dec 21, 2023
…s with animated misses

Resolves ppy#25987.

Structure is a bit clumsy but I'm not sure how to do better...
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
4 participants