Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

osu!taiko slider velocities are rounded to 2 decimal points, causing patterns to look staggered and unnatural #25862

Closed
mtz404 opened this issue Dec 18, 2023 · 5 comments · Fixed by #26616
Assignees
Labels
area:beatmap-parsing .osu file format parsing area:gameplay priority:1 Very important. Feels bad without fix. Affects the majority of users. ruleset/osu!taiko

Comments

@mtz404
Copy link

mtz404 commented Dec 18, 2023

Type

Game behaviour

Bug description

In stable, you can input sv's up to 16 decimal places. Lazer has rounded all of these sv's to 2 decimal places, causing patterns that use continuous sv's for speed ups and slow downs to look staggered at times, making it uncomfortable to read.

Many taiko mappers have become accustomed to using external programs that will generate sv slow downs and speed ups, so a sizeable number of ranked taiko maps and world cup tournament maps have these 16 decimal point sv values. Because of this I believe this is a urgent issue.

EDIT: After further investigation, I've found that this issue is most noticeable on maps with lower slider velocity, and maps with very gradual increase/decrease in slider velocity. This is because in both scenarios, you will be changing slider velocities every note by a small, but equal amount. When rounding these values to 2 decimal places, the changes in between slider velocities are no longer equal, causing the staggered effect seen below.

Screenshots or videos

The video provided shows a taiko world cup map which has this issue. It is hard to see the issue in real time so I recommend pausing to have a closer look. I have also provided a diagram of one pattern which hopefully better showcases this problem. Top players expect the smooth sv's seen in stable, so reading the disjointed one in lazer at the moment is very uncomfortable.

lazersv.mp4

imageardtda3452345

EDIT: Adding more examples.

Map 2: https://osu.ppy.sh/beatmapsets/1888593#taiko/3889528 at 01:07:401

lazersv3.mp4

Map 3: https://osu.ppy.sh/beatmapsets/1182264#taiko/2464974 at 02:32:385

lazersv5.mp4

Map 4: https://osu.ppy.sh/beatmapsets/1311567#taiko/2718349 at 02:43:830

lazersv5.mp4

Map 5: https://osu.ppy.sh/beatmapsets/1684883#taiko/3442563 at 01:08:582

This one is very hard to notice when not in gameplay so I recommend pausing. You should be able to notice very slight staggered notes, where 2 notes are closer together than one another.

lazersv6.mp4

Version

2023.1218.0-lazer

Logs

database.log
input.log
performance.log
runtime.log
network.log
1702919148.input.log
1702919148.performance.log
1702919148.runtime.log
1702919148.network.log

@bdach
Copy link
Collaborator

bdach commented Dec 18, 2023

please link the beatmap

@mtz404
Copy link
Author

mtz404 commented Dec 18, 2023

@peppy
Copy link
Member

peppy commented Jan 17, 2024

This probably needs to be addressed before scoring comes online if we're going to, as it will break replays and scores set.

@peppy peppy added the priority:1 Very important. Feels bad without fix. Affects the majority of users. label Jan 17, 2024
@bdach
Copy link
Collaborator

bdach commented Jan 17, 2024

as it will break replays and scores set

I don't... think so? Slider velocity is purely visual. It does not impact timing of hits.

Mind you, I don't disagree that this is an important issue (in fact it keeps lingering on my todo list), but it's not that critical.

@peppy
Copy link
Member

peppy commented Jan 17, 2024

Right, i'm used to SV affecting sliders.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
area:beatmap-parsing .osu file format parsing area:gameplay priority:1 Very important. Feels bad without fix. Affects the majority of users. ruleset/osu!taiko
Projects
None yet
Development

Successfully merging a pull request may close this issue.

3 participants