Editor does not read properties ignored on BeatmapInfo correctly

[salmonslay]

Type

Game behaviour

Bug description

When importing a beatmap, lazer will always default to using CountdownType.Normal with 0 offset, ignoring any values that the imported beatmap is using. This both applies to beatmaps imported from stable using the in-game wizard, .osz files and the in-game beatmap browser.

It seems like changing the offset in the editor actually gets saved, but turning off or changing the countdown speed is not.

I'll see if I can fix this myself as I need it for #20584. see comment

Screenshots or videos

Stable:

Lazer:

Version

master

Logs

[salmonslay]

It seems like these values are correctly decoded;

osu/osu.Game/Beatmaps/Formats/LegacyBeatmapDecoder.cs

Lines 220 to 226 in bff82a7

	case @"Countdown":
	beatmap.BeatmapInfo.Countdown = (CountdownType)Enum.Parse(typeof(CountdownType), pair.Value);
	break;
	case @"CountdownOffset":
	beatmap.BeatmapInfo.CountdownOffset = Parsing.ParseInt(pair.Value);
	break;

I also found a commit stating that CountdownType is intentionally ignored for now (d7fe358), and there was a discussion #14480 (review) about moving these values elsewhere. Would anyone else mind looking into this instead?

[bdach]

Renamed issue to describe the actual problem better.

The actual problem here - as outlined above - is that the beatmap decoder is supposed to fill the ignored countdown fields, but given the current structure of things this does not always happen. In particular the BeatmapInfo instance passed to the editor comes from the carousel, which does not attempt to fill the countdown values.

Obvious fixes such as the following do not work:

diff --git a/osu.Game/Screens/Select/SongSelect.cs b/osu.Game/Screens/Select/SongSelect.cs
index ece94b5365..cd631a4b44 100644
--- a/osu.Game/Screens/Select/SongSelect.cs
+++ b/osu.Game/Screens/Select/SongSelect.cs
@@ -346,7 +346,7 @@ public void Edit(BeatmapInfo beatmapInfo = null)
             if (!AllowEditing)
                 throw new InvalidOperationException($"Attempted to edit when {nameof(AllowEditing)} is disabled");

-            Beatmap.Value = beatmaps.GetWorkingBeatmap(beatmapInfo ?? beatmapInfoNoDebounce);
+            Beatmap.Value = beatmaps.GetWorkingBeatmap(beatmapInfo ?? beatmapInfoNoDebounce, true);
             this.Push(new EditorLoader());
         }

because WorkingBeatmap only decodes when accessing .Beatmap.

[bdach]

Likely also affects bookmarks as per https://discord.com/channels/188630481301012481/188630652340404224/1103223246020685834

[syzyxy]

Please fix bookmarks. Quite important for mappers.

[peppy]

We're aware and ongoing work is happening. You can follow progress on this at 46d1f00.