Add analyser which checks uniqueness of translation keys in a single file #63
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
bdach
commented
May 16, 2024
| namespace LocalisationAnalyser.Analysers | ||
| { | ||
| [DiagnosticAnalyzer(LanguageNames.CSharp)] | ||
| public class LocalisationKeyUsedMultipleTimesInClassAnalyser : DiagnosticAnalyzer |
There was a problem hiding this comment.
This purposefully does not inherit AbstractMemberAnalyser. I wanted to run the duplicate check exactly once per file, and I don't trust that any other method of passing data inside an analyser other than the stack is safe (as I have no idea what guarantees - if any - there are wrt threading and/or analyser lifetime, and there are indications online that there aren't any to guarantee that anything other than the stack is safe), so in order to not pollute AbstractMemberAnalyser with things specific to this check, I decided to just do away with inheritance and duplicate the few lines of logic it takes to reimplement it from scratch.
This was referenced May 16, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The goal here is to catch cases like ppy/osu#27472 and ppy/osu#28190 in an automated manner.
Have confirmed that on ppy/osu@f9fd1b9 this produces the following build errors:
and no others.