Shave allocation overheads in recent iOS texture loading code #6471
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
was going to mention this. good job finding and fixing yourself. |
peppy
approved these changes
Dec 23, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Noticed while attempting to migrate this to macOS, the
Croppart had allocation overhead with it (which...makes sense). Naive coding from my part.In case it's not clear already, it's not possible to directly load the image off of the
vImagepixel buffer as each row in the buffer has additional space at the end for performance reasons (memory alignment etc.). I've replaced the load-and-crop step with loading an empty image and copying row by row directly to memory.Time measuring of the texture loading process shows nothing bad, maybe good even (left master, right this PR):