FFmpeg: Enable MPEG-4 parser and decoder #6024
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Are the binaries available somewhere for testing? |
TIL you shouldn't really run `apt-get upgrade` in GitHub CI. Also removed some packages that are guaranteed to be installed already.
|
Sorry, yeah they are: https://github.com/FreezyLemon/osu-framework/actions/runs/6499895277 Had to remove |
|
Noticed another beatmap that doesn't work while testing: https://osu.ppy.sh/beatmapsets/10435#osu/42152 It uses "Sorenson Spark" video. I'll investigate and add another codec, I guess. |
|
New build artifacts, including the FLV/H.263/Sorenson Spark decoder: https://github.com/FreezyLemon/osu-framework/actions/runs/6500576741 |
peppy
approved these changes
Oct 13, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes ppy/osu#25086.
MPEG-4 Part 2 is a video coding standard that sits "between" H.262 and H.264. Xvid, DivX and some less known formats implement it.
FFmpeg supports these derivative codecs through the
mpeg4decoder, so to supportxvidanddivx(which seems to have been used in some beatmaps), this PR enables it and the according parser.Note that this does not depend on
libxvid, which is GPL.