-
Notifications
You must be signed in to change notification settings - Fork 424
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fix OpenUrlExternally
potentially crashing applications due to misconfigurations (and log errors instead)
#5989
Fix OpenUrlExternally
potentially crashing applications due to misconfigurations (and log errors instead)
#5989
Conversation
Added a try/catch statement to all overrides of the osu.Framework.Platform.GameHost.OpenUrlExternally method (in Desktop, IOS and Android platforms) for the bodies of the methods (excluding the url valid check).
…s and changed it to "Unable to open external link."
@bdach All of your suggestions have been resolved. |
OpenUrlExternally
potentially crashing applications due to misconfigurations (and log errors instead)
Not really worth it to split out the const, for one, and even if it was, then it _definitely_ should not live in `Logger` of all places.
The added Other than that, this is probably fine, as far as I can tell. I'm not sure the iOS variant makes sense, because I'm not sure if |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
see above
Okay, thank you. |
I don't think it does, but I also don't think it matters. This is mainly for desktop applications where it's been throwing. |
Added a try/catch statement to all overrides of the osu.Framework.Platform.GameHost.OpenUrlExternally method (in Desktop, IOS and Android platforms) for the bodies of the methods (excluding the url valid check).
Fixes ppy/osu#24696