Skip to content

Commit

Permalink
Issue #4 - Maven plugin is causing warnings during build
Browse files Browse the repository at this point in the history
* Fixed additional Maven warnings
  • Loading branch information
ppodgorsek committed Jan 15, 2019
1 parent 67851a4 commit 839165b
Show file tree
Hide file tree
Showing 3 changed files with 53 additions and 96 deletions.
96 changes: 49 additions & 47 deletions pom.xml
Original file line number Diff line number Diff line change
Expand Up @@ -53,10 +53,6 @@
<module>spring-test-dbunit-sample</module>
</modules>

<prerequisites>
<maven>3.2.3</maven>
</prerequisites>

<properties>
<project.build.sourceEncoding>UTF-8</project.build.sourceEncoding>
<java.version>1.8</java.version>
Expand Down Expand Up @@ -211,10 +207,6 @@
<artifactId>maven-clean-plugin</artifactId>
<version>${maven-clean-plugin.version}</version>
</plugin>
<plugin>
<artifactId>maven-javadoc-plugin</artifactId>
<version>${maven-javadoc-plugin.version}</version>
</plugin>
<plugin>
<artifactId>maven-compiler-plugin</artifactId>
<version>${maven-compiler-plugin.version}</version>
Expand All @@ -234,6 +226,9 @@
<artifactId>maven-eclipse-plugin</artifactId>
<version>${maven-eclipse-plugin.version}</version>
<configuration>
<downloadJavadocs>true</downloadJavadocs>
<downloadSources>true</downloadSources>

<additionalConfig>
<file>
<name>.settings/org.eclipse.jdt.ui.prefs</name>
Expand Down Expand Up @@ -290,44 +285,6 @@
<version>1.7</version>
</dependency>
</dependencies>
<configuration>
<reportPlugins>
<plugin>
<artifactId>maven-javadoc-plugin</artifactId>
<version>2.10.3</version>
</plugin>
<plugin>
<artifactId>maven-jxr-plugin</artifactId>
<version>2.5</version>
</plugin>
<plugin>
<artifactId>maven-pmd-plugin</artifactId>
<version>3.6</version>
<configuration>
<targetJdk>${java.version}</targetJdk>
</configuration>
</plugin>
<plugin>
<artifactId>maven-project-info-reports-plugin</artifactId>
<version>2.9</version>
</plugin>
<plugin>
<artifactId>maven-surefire-report-plugin</artifactId>
<version>2.19.1</version>
</plugin>
<plugin>
<groupId>org.codehaus.mojo</groupId>
<artifactId>cobertura-maven-plugin</artifactId>
<version>2.7</version>
<configuration>
<formats>
<format>xml</format>
<format>html</format>
</formats>
</configuration>
</plugin>
</reportPlugins>
</configuration>
</plugin>
<plugin>
<artifactId>maven-surefire-plugin</artifactId>
Expand All @@ -346,8 +303,13 @@
</executions>
</plugin>
<plugin>
<groupId>org.apache.maven.plugins</groupId>
<artifactId>maven-javadoc-plugin</artifactId>
<version>2.10.3</version>
<version>${maven-javadoc-plugin.version}</version>
<configuration>
<author>true</author>
<encoding>UTF-8</encoding>
</configuration>
<executions>
<execution>
<id>attach-javadocs</id>
Expand Down Expand Up @@ -377,4 +339,44 @@
</pluginManagement>
</build>

<reporting>
<plugins>
<plugin>
<groupId>org.apache.maven.plugins</groupId>
<artifactId>maven-javadoc-plugin</artifactId>
<version>${maven-javadoc-plugin.version}</version>
</plugin>
<plugin>
<artifactId>maven-jxr-plugin</artifactId>
<version>2.5</version>
</plugin>
<plugin>
<artifactId>maven-pmd-plugin</artifactId>
<version>3.6</version>
<configuration>
<targetJdk>${java.version}</targetJdk>
</configuration>
</plugin>
<plugin>
<artifactId>maven-project-info-reports-plugin</artifactId>
<version>2.9</version>
</plugin>
<plugin>
<artifactId>maven-surefire-report-plugin</artifactId>
<version>2.19.1</version>
</plugin>
<plugin>
<groupId>org.codehaus.mojo</groupId>
<artifactId>cobertura-maven-plugin</artifactId>
<version>2.7</version>
<configuration>
<formats>
<format>xml</format>
<format>html</format>
</formats>
</configuration>
</plugin>
</plugins>
</reporting>

</project>
2 changes: 2 additions & 0 deletions spring-test-dbunit-sample/pom.xml
Original file line number Diff line number Diff line change
Expand Up @@ -63,6 +63,7 @@
</plugin>
</plugins>
</build>

<dependencies>
<dependency>
<groupId>com.github.springtestdbunit</groupId>
Expand Down Expand Up @@ -122,4 +123,5 @@
<scope>test</scope>
</dependency>
</dependencies>

</project>
51 changes: 2 additions & 49 deletions spring-test-dbunit/pom.xml
Original file line number Diff line number Diff line change
Expand Up @@ -111,44 +111,6 @@
</plugin>
<plugin>
<artifactId>maven-site-plugin</artifactId>
<configuration>
<reportPlugins>
<plugin>
<artifactId>maven-javadoc-plugin</artifactId>
<version>2.10.3</version>
</plugin>
<plugin>
<artifactId>maven-jxr-plugin</artifactId>
<version>2.5</version>
</plugin>
<plugin>
<artifactId>maven-pmd-plugin</artifactId>
<version>3.6</version>
<configuration>
<targetJdk>${java.version}</targetJdk>
</configuration>
</plugin>
<plugin>
<artifactId>maven-project-info-reports-plugin</artifactId>
<version>2.9</version>
</plugin>
<plugin>
<artifactId>maven-surefire-report-plugin</artifactId>
<version>2.19.1</version>
</plugin>
<plugin>
<groupId>org.codehaus.mojo</groupId>
<artifactId>cobertura-maven-plugin</artifactId>
<version>2.7</version>
<configuration>
<formats>
<format>xml</format>
<format>html</format>
</formats>
</configuration>
</plugin>
</reportPlugins>
</configuration>
</plugin>
<plugin>
<artifactId>maven-surefire-plugin</artifactId>
Expand All @@ -164,17 +126,6 @@
</execution>
</executions>
</plugin>
<plugin>
<artifactId>maven-javadoc-plugin</artifactId>
<executions>
<execution>
<id>attach-javadocs</id>
<goals>
<goal>jar</goal>
</goals>
</execution>
</executions>
</plugin>
<plugin>
<groupId>com.github.github</groupId>
<artifactId>site-maven-plugin</artifactId>
Expand All @@ -192,6 +143,7 @@
</plugin>
</plugins>
</build>

<dependencies>
<!-- Expected Dependencies -->
<dependency>
Expand Down Expand Up @@ -262,4 +214,5 @@
<scope>test</scope>
</dependency>
</dependencies>

</project>

0 comments on commit 839165b

Please sign in to comment.